Change in vdsm[master]: vm: stats: periodic bulk stats sampling
danken at redhat.com
danken at redhat.com
Tue Mar 24 12:29:29 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: vm: stats: periodic bulk stats sampling
......................................................................
Patch Set 32:
(3 comments)
https://gerrit.ovirt.org/#/c/36722/32/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line 411: self._last_sample_time = 0
Line 412:
Line 413: def get(self, vmid):
Line 414: first_batch, last_batch, interval = self._samples.stats()
Line 415: if first_batch is None:
it's enough to check only first_batch for None
Line 416: first_sample = None
Line 417: else:
Line 418: first_sample = first_batch.get(vmid)
Line 419: if last_batch is None:
Line 448: try:
Line 449: if not self._sampling:
Line 450: self._sampling = True
Line 451: bulk_stats = self._conn.getAllDomainStats(self._statsFlags)
Line 452: else:
we should take this branch also if there are known doms to be skipped.
Line 453: # preempted a stuck sampling call
Line 454: doms = self._get_responsive_doms()
Line 455: self._log.debug('sampling %d domains', len(doms))
Line 456: if doms:
Line 465: finally:
Line 466: self._sampling = False
Line 467:
Line 468: def _get_responsive_doms(self):
Line 469: vms = self._cif.getVMs()
in another patch - please pass getVMs directly, so that _cif remains hidden.
Line 470: doms = []
Line 471: for vmId, vmObj in vms.iteritems():
Line 472: if vmId in self._skip_doms:
Line 473: continue
--
To view, visit https://gerrit.ovirt.org/36722
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2f1a62515059e663b418c6c7b61a15881980dc9
Gerrit-PatchSet: 32
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list