Change in vdsm[master]: ppc64le: fix cpuinfo caps parsing

danken at redhat.com danken at redhat.com
Tue Mar 24 11:31:39 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: ppc64le: fix cpuinfo caps parsing
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

I think that a function would have been nicer; future would tell.

https://gerrit.ovirt.org/#/c/39059/1/vdsm/caps.py
File vdsm/caps.py:

Line 193: 
Line 194: class CpuTopology(object):
Line 195:     def __init__(self, capabilities=None):
Line 196: 
Line 197:         if platform.machine() == Architecture.PPC64:
> As michal said; this patch is dealing with CpuInfo parsing, CpuTopology is 
ok
Line 198:             from ppc64HardwareInfo import \
Line 199:                 getCpuTopology as getPPC64CpuTopology
Line 200:             self._topology = getPPC64CpuTopology(capabilities)
Line 201:         else:


-- 
To view, visit https://gerrit.ovirt.org/39059
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I042e817e4f97866be3a762efb3cf7afdd3ecee7f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Madhu Pavan <kmp at linux.vnet.ibm.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list