Change in vdsm[master]: Adding Vdsm cron job check for available packages update

ybronhei at redhat.com ybronhei at redhat.com
Tue Mar 24 11:00:14 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: Adding Vdsm cron job check for available packages update
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/38401/4/vdsm/updater-tool
File vdsm/updater-tool:

Line 144:     outputPrint("checking updates for - %s" %
Line 145:                 (pkgList or 'all available packages'))
Line 146:     if args.provider == 'yum' and yumSupport:
Line 147:         updater = UpdaterTool(YumProvider)
Line 148:     elif args.provider == 'dnf' and dnfSupport:
> Nitpicking but maybe
if what? I don't understand your offer
Line 149:         updater = UpdaterTool(DnfProvider)
Line 150:     else:
Line 151:         outputPrint('Failed to initialize provider for %s' % args.provider)
Line 152: 


-- 
To view, visit https://gerrit.ovirt.org/38401
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f6b83e1c18c05142da095b0b537fa6d9aecb59e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list