Change in vdsm[master]: Fix MigrationStatus schema

shavivi at redhat.com shavivi at redhat.com
Tue Mar 24 08:50:49 UTC 2015


Shahar Havivi has uploaded a new change for review.

Change subject: Fix MigrationStatus schema
......................................................................

Fix MigrationStatus schema

MigrationStatus json schema is broken

Change-Id: I122d401eb9f7d03a5f886041a9203cb4c339756b
Signed-off-by: Shahar Havivi <shaharh at redhat.com>
---
M vdsm/rpc/vdsmapi-schema.json
1 file changed, 58 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/39078/1

diff --git a/vdsm/rpc/vdsmapi-schema.json b/vdsm/rpc/vdsmapi-schema.json
index 477f712..7fc9f30 100644
--- a/vdsm/rpc/vdsmapi-schema.json
+++ b/vdsm/rpc/vdsmapi-schema.json
@@ -6432,33 +6432,81 @@
  'returns': 'VmDefinition'}
 
 ##
-# @MigrationStatusInfo:
+# @MigrationStatus:
 #
-# Information regarding migration
-# on error return what cause the error
-# on success added actulal downtime of the VM
+# An enumeration of VM migration status.
 #
-# @downtime:  total time the the VM was offline
+# @done:        Migration completed
+#
+# @in_progress: Migration in progress
 #
 # Since: 4.17.0
 ##
-{'type', 'MigrationStatusInfo', 'data': {'downtime': 'str'}}
+{'enum': 'MigrationStatus', 'data': ['done', 'in_progress']}
+
+##
+# @MigratingStats:
+#
+# Statistics about the current ongoing migration of a VM
+#
+# @vmId:         The UUID of the Vm
+#
+# @status:       The current migration status of a VM
+#
+# @progress:     The migration percentage progress
+#
+# Since: 4.17.0
+##
+{'type': 'MigratingStats',
+ 'data': {'vmId': 'UUID', 'status': 'MigrationStatus',
+          'progress': 'uint'}}
+
+##
+# @MigratedStats:
+#
+# Statistics about the last completed migration of a VM
+#
+# @vmId:         The UUID of the Vm
+#
+# @status:       The current migration status of a VM
+#
+# @downtime:     The downtime the VM experienced
+#
+# Since: 4.17.0
+##
+{'type': 'MigratedStats',
+ 'data': {'vmId': 'UUID', 'status': 'MigrationStatus',
+          'downtime': 'uint'}}
+
+##
+# @MigrationStats:
+#
+# A discriminated record containing virtual machine migration statistics.
+# discriminating field: status. done -> MigratedStats; in_progress: MigratingStats
+#
+# Since: 4.17.0
+##
+{'type': 'MigrationStats',
+ 'data': {},
+ 'union': ['MigratedStats', 'MigratingStats']}
 
 ##
 # @VM.getMigrationStatus:
 #
-# Report status of a currently outgoing migration.
+# Report virtual machine migration statistics.
+# On going progress or statistics on done migration
 #
 # @vmID:  The UUID of the VM
 #
+# Returns:
+# Statistics on ongoing migration or done migration
+#
 # Since: 4.10.0
 #
-# Notes: Migration status is returned as the command status ('code' and
-#        'message')
 ##
 {'command': {'class': 'VM', 'name': 'getMigrationStatus'},
  'data': {'vmID': 'UUID'},
- 'returns': 'MigrationStatusInfo'}
+ 'returns': 'MigrationStats'}
 
 ##
 # @VmExitCode:


-- 
To view, visit https://gerrit.ovirt.org/39078
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I122d401eb9f7d03a5f886041a9203cb4c339756b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>


More information about the vdsm-patches mailing list