Change in vdsm[master]: schema: temporarily hide getMigrationStatus return

fromani at redhat.com fromani at redhat.com
Tue Mar 24 08:22:26 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: schema: temporarily hide getMigrationStatus return
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/39062/1//COMMIT_MSG
Commit Message:

Line 7: schema: temporarily hide getMigrationStatus return
Line 8: 
Line 9: Commit b8df0ff261c unveiled a dark corner of VDSM
Line 10: and highlighted that the return value of
Line 11: VM.getMigrationStatus() API is inconsistent
> can you tell more about that dark corner?
The dark corner is made of two dark spots:
- for VM_getMigrationStatus verb, we pollute our standard response  {'status': {'code': X, 'message': SOMETHING}} with more top level keys, which is unusual and clutters the API. Most notably {'progress': Y, 'status': {'code': X, 'message': SOMETHING}}. This is actaully my bad, back in time I didn't noticed that the added 'progress' key was exported at API level. However.

- the schema is actually wrong, as we don't return a MigrationStatusInfo type, but rather an augmented status as I reported above

So, this patch _is_ a temporary hack/fix because we still have an inconstency between code and schema, but we trade an explicit inconsistency for a subtler one, which has the only benefit to unbreak master.
Line 12: and not passes the schema validation.
Line 13: 
Line 14: This patch reverts the schema change and unbreaks
Line 15: the build until we figure out the proper clean fix.


-- 
To view, visit https://gerrit.ovirt.org/39062
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86b15d626314e679b7fecb6d40cb9d950086fe27
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list