Change in vdsm[master]: ppc64: unable to list online logical CPUs

danken at redhat.com danken at redhat.com
Mon Mar 23 22:15:16 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: ppc64: unable to list online logical CPUs
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/38983/3/tests/capsTests.py
File tests/capsTests.py:

Line 90:                         '9', '10', '11', '12', '13', '14', '15']
Line 91:         testPath = os.path.realpath(__file__)
Line 92:         dirName = os.path.split(testPath)[0]
Line 93: 
Line 94:         # Using parseCpus to get cpus list
I am looking for a more extensive test, with more complex inputs. You don't test any input with coma, for example.
Line 95:         parseCpus = ppc64HardwareInfo._parse_cpu_list(value)
Line 96:         self.assertEqual(parseCpus, expectedCpus)
Line 97: 
Line 98:         # Using caps_lscpu_ppc64_1_4_4.out to get cpus list


Line 98:         # Using caps_lscpu_ppc64_1_4_4.out to get cpus list
Line 99:         path = os.path.join(dirName, "caps_lscpu_ppc64_1_4_4.out")
Line 100:         with open(path) as p:
Line 101:             t = caps.CpuTopology(p.read())
Line 102:         self.assertEqual(t.onlineCpus(), expectedCpus)
These assertions are better included in the existing test, like you have done Ina previous patchset.
Line 103: 
Line 104:         # Comparing output of parseCpus and caps_lscpu_ppc64_1_4_4.out
Line 105:         self.assertEqual(t.onlineCpus(), parseCpus)
Line 106: 


-- 
To view, visit https://gerrit.ovirt.org/38983
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5c4bdbc00217516ba3b7e361ab28e409c507baa
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Madhu Pavan <kmp at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Madhu Pavan <kmp at linux.vnet.ibm.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list