Change in vdsm[master]: storage: Make StorageDomain._getRepoPath public

alitke at redhat.com alitke at redhat.com
Mon Mar 23 20:38:31 UTC 2015


Adam Litke has uploaded a new change for review.

Change subject: storage: Make StorageDomain._getRepoPath public
......................................................................

storage: Make StorageDomain._getRepoPath public

This method is needed by the new SDM code to perform operations on
images and volumes.  Make it public.

Change-Id: I92b6604df74b0d984895c6e0d4f8ff7007403e37
Signed-off-by: Adam Litke <alitke at redhat.com>
---
M vdsm/storage/fileSD.py
M vdsm/storage/sd.py
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/39066/1

diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py
index 9ceda8d..1220939 100644
--- a/vdsm/storage/fileSD.py
+++ b/vdsm/storage/fileSD.py
@@ -641,7 +641,7 @@
             return
         templateImage = tImgs[0]
         relinkImgs = tuple(tImgs[1:])
-        repoPath = self._getRepoPath()
+        repoPath = self.getRepoPath()
         basePath = os.path.join(repoPath, self.sdUUID, sd.DOMAIN_IMAGES)
         volFiles = [volUUID, volUUID + fileVolume.META_FILEEXT]
         if self.hasVolumeLeases():
diff --git a/vdsm/storage/sd.py b/vdsm/storage/sd.py
index a771abf..bbec420 100644
--- a/vdsm/storage/sd.py
+++ b/vdsm/storage/sd.py
@@ -426,7 +426,7 @@
         Create a new volume
         """
         return self.getVolumeClass().create(
-            self._getRepoPath(), self.sdUUID, imgUUID, size, volFormat,
+            self.getRepoPath(), self.sdUUID, imgUUID, size, volFormat,
             preallocate, diskType, volUUID, desc, srcImgUUID, srcVolUUID)
 
     def getMDPath(self):
@@ -658,7 +658,7 @@
             self.mountMaster()
             self.createMasterTree()
 
-    def _getRepoPath(self):
+    def getRepoPath(self):
         # This is here to make sure no one tries to get a repo
         # path from an ISO domain.
         if self.getDomainClass() == ISO_DOMAIN:
@@ -668,7 +668,7 @@
         return os.path.join(self.storage_repository, self.getPools()[0])
 
     def getLinkBCImagePath(self, imgUUID):
-        return image.Image(self._getRepoPath()) \
+        return image.Image(self.getRepoPath()) \
                     .getImageDir(self.sdUUID, imgUUID)
 
     def getIsoDomainImagesDir(self):


-- 
To view, visit https://gerrit.ovirt.org/39066
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I92b6604df74b0d984895c6e0d4f8ff7007403e37
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>


More information about the vdsm-patches mailing list