Change in vdsm[master]: schema: temporarily hide getMigrationStatus return

danken at redhat.com danken at redhat.com
Mon Mar 23 17:27:26 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: schema: temporarily hide getMigrationStatus return
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/39062/1//COMMIT_MSG
Commit Message:

Line 7: schema: temporarily hide getMigrationStatus return
Line 8: 
Line 9: Commit b8df0ff261c unveiled a dark corner of VDSM
Line 10: and highlighted that the return value of
Line 11: VM.getMigrationStatus() API is inconsistent
can you tell more about that dark corner?
I'd rather mark this explicitly in a specific @brokentest() decorator, over reverting to our state of ignorance.
Line 12: and not passes the schema validation.
Line 13: 
Line 14: This patch reverts the schema change and unbreaks
Line 15: the build until we figure out the proper clean fix.


-- 
To view, visit https://gerrit.ovirt.org/39062
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86b15d626314e679b7fecb6d40cb9d950086fe27
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list