Change in vdsm[master]: ceph: Initial support for network disk

nsoffer at redhat.com nsoffer at redhat.com
Mon Mar 23 14:18:20 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: ceph: Initial support for network disk
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/38766/4/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 2627:           'apparentsize': 'uint', 'index': 'int', 'name': 'str',
Line 2628:           'optional': 'bool', 'shared': 'VmSharedDriveType',
Line 2629:           'truesize': 'uint', 'volumeChain': ['VmDiskDeviceVolumeChainEntry'],
Line 2630:           '*baseVolumeID': 'UUID', '*diskType': 'str',
Line 2631:           '*hosts': ['NetworkDiskHostInfo'], '*protocol': 'str'}}
> It would be good to adopt/reuse already existing like StorageDomainType.
Vdsm is not interested in protocol, I could not care less what value will be there.

diskType is important, and we will add constant for this later.

I don't know how StorageDomainType is passed in the request, but diskType will be passed as a string (e.g, "network") - we will not use any more numeric enum-like input arguments, only human readable arguments.
Line 2632: 
Line 2633: ##
Line 2634: # @VmInterfaceDeviceType:
Line 2635: #


-- 
To view, visit https://gerrit.ovirt.org/38766
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c5792bb6206a227ee0c2df9490b771a69c0093c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list