Change in vdsm[master]: ceph: Initial support for network disk

nsoffer at redhat.com nsoffer at redhat.com
Mon Mar 23 14:11:02 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: ceph: Initial support for network disk
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/38766/4/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:

Line 311:             
> Maybe a dumb question - but where does hosts get populated?
Anything passed to __init__ is passed to the base class __init__, and finally is assigned to the instance in virt.vmdevices.code.Base.__init__.

We assume here that drive was initialized with valid hosts list.

We probably need to add validation of input data, but this is true for most other attributes.

You can see an example in tests/vmStorageTests.py


-- 
To view, visit https://gerrit.ovirt.org/38766
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c5792bb6206a227ee0c2df9490b771a69c0093c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list