Change in vdsm[master]: clientIF: stop VmStatsThread on shutdown

fromani at redhat.com fromani at redhat.com
Mon Mar 23 11:58:56 UTC 2015


Francesco Romani has uploaded a new change for review.

Change subject: clientIF: stop VmStatsThread on shutdown
......................................................................

clientIF: stop VmStatsThread on shutdown

Explicitily stop VmStatsThreads when VDSM is shutting down.
This patch makes the flow faster and safer when libvirtd crashes
Without this patch, the VmStatsThread exit on shutdown because
they find Vm._dom equals None, and they exit with a stacktrace
as soon as they woke up for their polling.

With this patch, we make things explicit.

Relates-To: https://bugzilla.redhat.com/1203210
Change-Id: Id1c01f7a3ea1c22ba0d64b39fb74393e9a52e236
Signed-off-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/clientIF.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/39038/1

diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index 839957e..2719101 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -239,6 +239,8 @@
             self._enabled = False
             self.channelListener.stop()
             self._hostStats.stop()
+            for vm_obj in self.vmContainer.values():
+                vm_obj.stopVmStats()
             if self.mom:
                 self.mom.stop()
             if self.irs:


-- 
To view, visit https://gerrit.ovirt.org/39038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1c01f7a3ea1c22ba0d64b39fb74393e9a52e236
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>


More information about the vdsm-patches mailing list