Change in vdsm[master]: virt: driver
danken at redhat.com
danken at redhat.com
Mon Mar 23 11:36:38 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: virt: driver
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/39034/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4515: dev['address'] = address
Line 4516: dev['alias'] = alias
Line 4517: dev['name'] = name
Line 4518: dev['linkActive'] = linkActive
Line 4519: dev['driver'] = driver
no need to expose "driver" in conf. Engine is not expected to know what to do with it, anyway.
Line 4520: knownDev = True
Line 4521: # Add unknown nic device to vm's conf
Line 4522: if not knownDev:
Line 4523: nicDev = {'type': hwclass.NIC,
--
To view, visit https://gerrit.ovirt.org/39034
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I043b1c4b932cf0bc83b1f911415245e858ae350d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list