Change in vdsm[master]: ceph: Initial support for network disk

fromani at redhat.com fromani at redhat.com
Mon Mar 23 10:29:50 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: ceph: Initial support for network disk
......................................................................


Patch Set 4: Code-Review+1

(3 comments)

nice improvement, added inline comments about possible further improvements for future patches.

https://gerrit.ovirt.org/#/c/38766/4/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 2541: #
Line 2542: # Since: 4.17.0
Line 2543: ##
Line 2544: {'type': 'NetworkDiskHostInfo',
Line 2545:  'data': {'name': 'str', 'port': 'str', 'transport': 'str'}}
for a future patch: do we want something stricter than 'str' for port and transport? Maybe new enums?
Line 2546: 
Line 2547: ##
Line 2548: # @VmDiskDevice:
Line 2549: #


Line 2627:           'apparentsize': 'uint', 'index': 'int', 'name': 'str',
Line 2628:           'optional': 'bool', 'shared': 'VmSharedDriveType',
Line 2629:           'truesize': 'uint', 'volumeChain': ['VmDiskDeviceVolumeChainEntry'],
Line 2630:           '*baseVolumeID': 'UUID', '*diskType': 'str',
Line 2631:           '*hosts': ['NetworkDiskHostInfo'], '*protocol': 'str'}}
Same: do we want to add some new enums here for diskType and protocol?
Line 2632: 
Line 2633: ##
Line 2634: # @VmInterfaceDeviceType:
Line 2635: #


https://gerrit.ovirt.org/#/c/38766/4/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:

Line 170:         return self.blockDev and self.format == "cow"
Line 171: 
Line 172:     @property
Line 173:     def networkDev(self):
Line 174:         return getattr(self, 'diskType', None) == 'network'
for a future patch: we may want to use constants here as well.
Line 175: 
Line 176:     @property
Line 177:     def blockDev(self):
Line 178:         if self._blockDev is None:


-- 
To view, visit https://gerrit.ovirt.org/38766
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c5792bb6206a227ee0c2df9490b771a69c0093c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list