Change in vdsm[ovirt-3.5]: monitor: return whether the reported status is actual

nsoffer at redhat.com nsoffer at redhat.com
Mon Mar 23 09:56:03 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: monitor: return whether the reported status is actual
......................................................................


Patch Set 4: Code-Review-1

(4 comments)

This should be more like the upstream version, making non-actual status explicit.

https://gerrit.ovirt.org/#/c/38874/4/vdsm/storage/domainMonitor.py
File vdsm/storage/domainMonitor.py:

Line 37
Line 38
Line 39
Line 40
Line 41
Please add actual argument to init, like the upstream version.


Line 152
Line 153
Line 154
Line 155
Line 156
Use actual=False


Line 153
Line 154
Line 155
Line 156
Line 157
Use actual=False if you like.


Line 38:         "isoPrefix", "version", "actual",
Line 39:     )
Line 40: 
Line 41:     def __init__(self):
Line 42:         self.clear(actual=False)
Call with given argument.
Line 43: 
Line 44:     def clear(self, actual=True):
Line 45:         self.actual = actual
Line 46:         self.error = None


-- 
To view, visit https://gerrit.ovirt.org/38874
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fea518991a76ea0f9ff1ff5258afe95bca2f00d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list