Change in vdsm[master]: vm: Introduce Vm._getVolumeSize() method

nsoffer at redhat.com nsoffer at redhat.com
Mon Mar 23 09:27:11 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: vm: Introduce Vm._getVolumeSize() method
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/37888/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3118:                 vmDrive.domainID, vmDrive.poolID, vmDrive.imageID,
Line 3119:                 vmDrive.volumeID)
Line 3120:         except StorageUnavailableError as e:
Line 3121:             self.log.error("Unable to update drive %s volume size: %s",
Line 3122:                            vmDrive.name, e)
> then maybe just self.log.exception()?
The traceback is not interesting - we called hsm api and it failed, logging exception in dispatcher wrapper.
Line 3123:             return
Line 3124: 
Line 3125:         vmDrive.truesize = volSize.truesize
Line 3126:         vmDrive.apparentsize = volSize.apparentsize


-- 
To view, visit https://gerrit.ovirt.org/37888
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2767cb8d7560b0eb1ad950f0844a8e24347139e4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Candace Sheremeta <cshereme at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list