Change in vdsm[master]: lib: introduce the 'response' module

danken at redhat.com danken at redhat.com
Sun Mar 22 20:16:06 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: lib: introduce the 'response' module
......................................................................


lib: introduce the 'response' module

It happens sometimes that it is needed to overwrite
the predefined error message with something more
specific to the circumstances.

In general, the handling of response code
feels clumsier than it should.

To improve things, we bootstrap the little helper
'response' module, starting with a function
which allow to override the error message.

Change-Id: Ife293080c2c6654315a609478f3276c9008ea6e7
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/37912
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M debian/vdsm-python.install
M lib/vdsm/Makefile.am
A lib/vdsm/response.py
M tests/Makefile.am
A tests/responseTests.py
M vdsm.spec.in
6 files changed, 81 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/37912
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ife293080c2c6654315a609478f3276c9008ea6e7
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list