Change in vdsm[master]: storage: Remove validateStorageServerConnection

danken at redhat.com danken at redhat.com
Sun Mar 22 18:03:19 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: storage: Remove validateStorageServerConnection
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/38230/3/vdsm/dsaversion.py.in
File vdsm/dsaversion.py.in:

Line 32: version_info = {
Line 33:     'version_name': version_name,
Line 34:     'software_version': software_version,
Line 35:     'software_revision': software_revision,
Line 36:     'supportedENGINEs': ['3.3', '3.4', '3.5', '3.6'],
> I disagree. There is no agenda to remove older engines - it's an (unfortuna
I always forget the Engine-side semantics of supportedENGINEs and clusterLevel. But I think that the removed API calls were part of the required verbs in clusterLevel <= 3.2. I think we don't want Vdsm without them to join ancient clusters. Thus I believe that we need to drop clusterLevels <= 3.2, too.
Line 37:     'supportedProtocols': ['2.2', '2.3'],
Line 38:     'clusterLevels': ['3.0', '3.1', '3.2', '3.3', '3.4', '3.5', '3.6'],


-- 
To view, visit https://gerrit.ovirt.org/38230
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c0f3678005c4075098f134a628fef1f3fc8e612
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list