Change in vdsm[master]: storage: introducing vdsm-dump-chains script
nsoffer at redhat.com
nsoffer at redhat.com
Sat Mar 21 22:35:10 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: storage: introducing vdsm-dump-chains script
......................................................................
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/38281/7/client/vdsm_dump_chains.py
File client/vdsm_dump_chains.py:
Line 41:
Line 42: class ChainError(Exception):
Line 43: def __init__(self, volumes_children):
Line 44: super(ChainError, self).__init__()
Line 45: self.volumes_children = volumes_children
> Lets stick with the current name, as it describes the data structure itself
ok
Line 46:
Line 47: def __str__(self):
Line 48: return 'volumes and parents: ' + ' '.join(
Line 49: ['%s<-%s' % (p, c) for p, c in self.volumes_children])
--
To view, visit https://gerrit.ovirt.org/38281
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I428c443bb7d6b2a504a6f77efcd4838f7ae6c404
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vladik Romanovsky <vladik.romanovsky at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list