Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue

barumuga at redhat.com barumuga at redhat.com
Sat Mar 21 00:57:07 UTC 2015


Bala.FA has posted comments on this change.

Change subject: gluster: fix build error in F20 due to blivet version issue
......................................................................


Patch Set 8: Code-Review-1

(4 comments)

https://gerrit.ovirt.org/#/c/38942/8/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 256: create
Can you confirm with blivet team about older version accepts size as (int/float only) whereas latest version accepts size as only Size object?

It looks like a breakage in the latest blivet.


Line 259: supportSizeObj
supportSizeObj should be a separate logic after _pvCreate()


Line 259: supportSizeObj
supportSizeObj should be a separate logic after _pvCreate()


Line 280: value
Can you confirm with blivet team about this?


-- 
To view, visit https://gerrit.ovirt.org/38942
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list