Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue
tjeyasin at redhat.com
tjeyasin at redhat.com
Fri Mar 20 23:27:23 UTC 2015
Timothy Asir has posted comments on this change.
Change subject: gluster: fix build error in F20 due to blivet version issue
......................................................................
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/38942/5/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:
Line 246: pvDeviceList = _createPV(pvDeviceList, alignment)
Line 247:
Line 248: supportSizeObj = True
Line 249: stripeSize = raidParams.get('stripeSize', 0)
Line 250: if isinstance(deviceList[0].size, size.Size):
> Its better to check pvDeviceList[0].size?
Done
Line 251: if stripeSize:
Line 252: stripeSize = size.Size('%s KiB' % stripeSize)
Line 253: else:
Line 254: supportSizeObj = False
Line 267: metaDataSize = vgSizeKib * MIN_METADATA_PERCENT
Line 268: else:
Line 269: vgSizeKib = vg.size * 1024
Line 270: if vg.size < MIN_VG_SIZE:
Line 271: metaDataSize = vgSizeKib * MIN_METADATA_PERCENT
> vg.size < MIN_VG_SIZE should be out of if supportSizeObj
Done
Line 272: poolDataSize = vgSizeKib - metaDataSize
Line 273: metaDataSize = (metaDataSize - (metaDataSize % alignment))
Line 274: poolDataSize = (poolDataSize - (poolDataSize % alignment))
Line 275: if supportSizeObj:
--
To view, visit https://gerrit.ovirt.org/38942
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list