Change in vdsm[master]: asyncore: heartbeat fix

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Fri Mar 20 16:17:18 UTC 2015


Hello Saggi Mizrahi,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/38988

to review the following change.

Change subject: asyncore: heartbeat fix
......................................................................

asyncore: heartbeat fix

When getting new timeout for asyncore loop we get None several times in
a row we are forced to wait for dispatcher event. We expect to process
heartbeat events so we need to set timeout to asyncore default value
which is 30 seconds.

Change-Id: Icad61fb62509764e8ecdd6f87ef60557f4465368
Signed-off-by: Saggi Mizrahi <smizrahi at redhat.com>
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
---
M lib/yajsonrpc/betterAsyncore.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/38988/1

diff --git a/lib/yajsonrpc/betterAsyncore.py b/lib/yajsonrpc/betterAsyncore.py
index 7101768..2f1122d 100644
--- a/lib/yajsonrpc/betterAsyncore.py
+++ b/lib/yajsonrpc/betterAsyncore.py
@@ -203,7 +203,7 @@
         self._map.clear()
 
     def _get_timeout(self, map):
-        timeout = None
+        timeout = 30.0
         for disp in self._map.values():
             if hasattr(disp, "next_check_interval"):
                 interval = disp.next_check_interval()


-- 
To view, visit https://gerrit.ovirt.org/38988
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icad61fb62509764e8ecdd6f87ef60557f4465368
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list