Change in vdsm[master]: Have the protocol detector use the Reactor

danken at redhat.com danken at redhat.com
Fri Mar 20 15:22:02 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Have the protocol detector use the Reactor
......................................................................


Have the protocol detector use the Reactor

The current implementation duplicates a lot of the code in the reactor.
This removes a lot of the duplicate code and prepares the ground for a
single reactor for VDSM.

Change-Id: If1cc2a205cdad335e8c3af4a77ed49c8977a79ba
Signed-off-by: Saggi Mizrahi <smizrahi at redhat.com>
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
Reviewed-on: https://gerrit.ovirt.org/37098
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/sslutils.py
M lib/yajsonrpc/__init__.py
M lib/yajsonrpc/betterAsyncore.py
M lib/yajsonrpc/stompReactor.py
M tests/jsonRpcHelper.py
M tests/protocoldetectorTests.py
M vdsm/protocoldetector.py
M vdsm/rpc/BindingXMLRPC.py
8 files changed, 275 insertions(+), 252 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/37098
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If1cc2a205cdad335e8c3af4a77ed49c8977a79ba
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list