Change in vdsm[master]: functional tests: add basic device verification
fromani at redhat.com
fromani at redhat.com
Fri Mar 20 14:28:55 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: functional tests: add basic device verification
......................................................................
Patch Set 1:
(1 comment)
very nicely done. Thanks!
https://gerrit.ovirt.org/#/c/38980/1/tests/functional/virtTests.py
File tests/functional/virtTests.py:
Line 242:
Line 243: # Every alias has to be unique to the host. If this
Line 244: # condition doesn't hold, we may have identified the same XML chunk
Line 245: # as two different devices
Line 246: self.assertTrue(len(aliases) == len(set(aliases)))
assertEqual is slightly better
Line 247:
Line 248:
Line 249: @expandPermutations
Line 250: class VirtTest(VirtTestBase):
--
To view, visit https://gerrit.ovirt.org/38980
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I88ca6630ad047fbc1d9b036e1112bf5db41dc24d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list