Change in vdsm[master]: vm: do not poll for scheduler parameters

danken at redhat.com danken at redhat.com
Fri Mar 20 12:12:24 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: do not poll for scheduler parameters
......................................................................


vm: do not poll for scheduler parameters

The scheduler parameters aren't actually stats, but
configuration data[1], which will not change unless
someone asks libvirt to do so.

VDSM is supposed to be the lone controller of libvirt,
so it is safe to assume (as we already do in a quite
lot of flows) that nothing will change behind his back.

So, stop to poll for scheduler parameters, and store
the change instead.

A future patch will add support for tune events, in
the (unlikely) case someone else indeed start
to mess around with libvirt bypassing VDSM.

+++

[1] as we were reminded into
https://bugzilla.redhat.com/show_bug.cgi?id=1199002#c2

Change-Id: I375065b964dd63d19a804e9a9ebd90a2f98153fb
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/38483
Reviewed-by: Martin Sivák <msivak at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/vmTests.py
M vdsm/virt/vm.py
2 files changed, 74 insertions(+), 48 deletions(-)

Approvals:
  Martin Sivák: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/38483
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I375065b964dd63d19a804e9a9ebd90a2f98153fb
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list