Change in vdsm[master]: stomp: Pop the frame even if a frame handler isn't defined

fromani at redhat.com fromani at redhat.com
Fri Mar 20 08:07:11 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: stomp: Pop the frame even if a frame handler isn't defined
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/35940/10//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-12-07 22:57:37 +0200
Line 4: Commit:     pkliczewski <piotr.kliczewski at gmail.com>
Line 5: CommitDate: 2015-03-18 12:08:18 +0100
Line 6: 
Line 7: stomp: Pop the frame even if a frame handler isn't defined
ok, but why? We don't we need the hasattr() check anymore?
Why is this not going to explode?
Line 8: 
Line 9: Change-Id: I9cd3c5b9ad70cf49e1b105260548720d5b34ea9a
Line 10: Signed-off-by: Saggi Mizrahi <smizrahi at redhat.com>


-- 
To view, visit https://gerrit.ovirt.org/35940
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cd3c5b9ad70cf49e1b105260548720d5b34ea9a
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list