Change in vdsm[master]: jsonrpc: events

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Fri Mar 20 07:49:12 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpc: events
......................................................................


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/38069/10/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 145: 
Line 146:     def _send_notification(self, message, destination):
Line 147:         json_binding = self.bindings['jsonrpc']
Line 148:         server = json_binding.getStompReactor().server
Line 149:         server.send(message)
> We have two problems here.
We need a means to give people ability to send notifications. ClientIF is now used by most of the code which makes it ugly but good trash can. I am open for other commonly used parts of the code which could hold events infra code for sending.

I agree with you and we should simplify the code. Will work on it.
Line 150: 
Line 151:     def contEIOVms(self, sdUUID, isDomainStateValid):
Line 152:         # This method is called everytime the onDomainStateChange
Line 153:         # event is emitted, this event is emitted even when a domain goes


-- 
To view, visit https://gerrit.ovirt.org/38069
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id27b5ca1773139932eb5cb16921d5abec4991c5e
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list