Change in vdsm[master]: vm: method to check if dom is ready for commands

fromani at redhat.com fromani at redhat.com
Fri Mar 20 07:14:55 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vm: method to check if dom is ready for commands
......................................................................


Patch Set 28:

(1 comment)

https://gerrit.ovirt.org/#/c/36721/28/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3003:         """
Line 3004:         Returns True only in the safest condition, False otherwise
Line 3005:         This method is meant to filter out known-bad situations
Line 3006:         not to asses known-good ones.
Line 3007:         False negative (domain is reported NOT ready, but it is) are possible
The above two lines makes the docstring confusing. Drop them.
Line 3008:         False positive (domain is reported ready, but it is NOT) are avoided
Line 3009:         """
Line 3010:         try:
Line 3011:             state, details, stateTime = self._dom.controlInfo()


-- 
To view, visit https://gerrit.ovirt.org/36721
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6fa253326778a102591af4ef5f2bb0434d1eade6
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list