Change in vdsm[master]: gluster: fix build error in F20 due to blivet version issue

tjeyasin at redhat.com tjeyasin at redhat.com
Fri Mar 20 06:55:19 UTC 2015


Timothy Asir has posted comments on this change.

Change subject: gluster: fix build error in F20 due to blivet version issue
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/38942/3/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 182:                 poolMetaDataSize = size.Size('%d KiB' % poolMetaDataSize)
Line 183:                 poolDataSize = size.Size('%d KiB' % poolDataSize)
Line 184:             else:
Line 185:                 poolMetaDataSize = poolMetaDataSize / 1024.0
Line 186:                 poolDataSize = poolDataSize / 1024.0
> Do this logic in the caller itself as its done for createVg to make it more
Done
Line 187:             metaLv = LVMLogicalVolumeDevice(
Line 188:                 metaName, parents=[vg], size=poolMetaDataSize)
Line 189:             poolLv = LVMLogicalVolumeDevice(
Line 190:                 poolName, parents=[vg], size=poolDataSize)


Line 251:     pvDeviceList = _makePartition(deviceList)
Line 252:     pvDeviceList = _createPV(pvDeviceList, alignment)
Line 253: 
Line 254:     stripeSize = raidParams.get('stripeSize', 0)
Line 255:     if isinstance(deviceList[0].size, size.Size):
> This check result can be extracted to a variable like 'sizeSupported' and c
Done
Line 256:         if stripeSize:
Line 257:             stripeSize = size.Size('%s KiB' % stripeSize)
Line 258:     else:
Line 259:         stripeSize = stripeSize / 1024.0


-- 
To view, visit https://gerrit.ovirt.org/38942
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf2af69637b7d247225433a7736c49f6c5fefe1d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list