Change in vdsm[ovirt-3.5]: call named arguments with their name

ykaplan at redhat.com ykaplan at redhat.com
Thu Mar 19 12:58:29 UTC 2015


Hello Yaniv Bronhaim, Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/38939

to review the following change.

Change subject: call named arguments with their name
......................................................................

call named arguments with their name

Change-Id: I05bc4358522dfaafa9a91ca58b4b18ecd04065f9
Signed-off-by: Yeela Kaplan <ykaplan at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/38774
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/SecureXMLRPCServer.py
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/38939/1

diff --git a/lib/vdsm/SecureXMLRPCServer.py b/lib/vdsm/SecureXMLRPCServer.py
index bbff2b9..8805f87 100644
--- a/lib/vdsm/SecureXMLRPCServer.py
+++ b/lib/vdsm/SecureXMLRPCServer.py
@@ -136,8 +136,11 @@
         # urf. compensate for bad input.
         if port == 0:
             port = None
-        self._setup(self._connection_class(host, port, key_file,
-                                           cert_file, strict,
+        self._setup(self._connection_class(host=host,
+                                           port=port,
+                                           key_file=key_file,
+                                           cert_file=cert_file,
+                                           strict=strict,
                                            ca_certs=ca_certs,
                                            cert_reqs=cert_reqs))
 


-- 
To view, visit https://gerrit.ovirt.org/38939
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I05bc4358522dfaafa9a91ca58b4b18ecd04065f9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list