Change in vdsm[master]: split network restoration from vdsmd.service

danken at redhat.com danken at redhat.com
Thu Mar 19 11:59:10 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: split network restoration from vdsmd.service
......................................................................


Patch Set 18: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/29441/18/init/systemd/vdsm-network.service.in
File init/systemd/vdsm-network.service.in:

Line 7: [Service]
Line 8: Type=oneshot
Line 9: EnvironmentFile=-/etc/sysconfig/vdsm
Line 10: ExecStartPre=@BINDIR@/vdsm-tool --vvverbose --append --logfile=@VDSMLOGDIR@/upgrade.log upgrade-unified-persistence
Line 11: ExecStartPre=@BINDIR@/vdsm-tool --vvverbose --append --logfile=@VDSMLOGDIR@/upgrade.log upgrade-3.0.0-networks
on a separate patch - upgrade-3.0.0 BEFORE the new upgrade-unified
Line 12: ExecStart=@VDSMDIR@/vdsm-restore-net-config
Line 13: RemainAfterExit=yes
Line 14: 
Line 15: [Install]


https://gerrit.ovirt.org/#/c/29441/18/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:

Line 17: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
Line 18: #
Line 19: # Refer to the README and COPYING files for full details of the license
Line 20: #
Line 21: import optparse
please keep sorted; and better use argparse, just like vdsm-tool
Line 22: import logging
Line 23: import logging.config
Line 24: import sys
Line 25: import os


Line 166:                             level=logging.DEBUG)
Line 167:         logging.error('Could not init proper logging', exc_info=True)
Line 168: 
Line 169:     parser = optparse.OptionParser("usage: %prog [options] nets_restored_mark")
Line 170:     force_option_help = "the restore action first tests for an existence of " \
"restore networks even if the " + _NETS_RESTORED_MARK + "mark exists. The mark is created upon a previous successful restore"
Line 171:                         "a mark that is made after the last successful " \
Line 172:                         "restore action. Unless this option is used, " \
Line 173:                         "restore will be a no-op if this mark exists."
Line 174:     parser.add_option('--force', action='store_true', default=False,


-- 
To view, visit https://gerrit.ovirt.org/29441
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70cdf1e8a1e7063ec850081ac6199728d4cde381
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <toni+ovirt at midokura.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni+ovirt at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list