Change in vdsm[master]: lvm: Update hsm.__processVGInfos() with lvm.getPV() new API

ishaby at redhat.com ishaby at redhat.com
Thu Mar 19 11:51:42 UTC 2015


Idan Shaby has posted comments on this change.

Change subject: lvm: Update hsm.__processVGInfos() with lvm.getPV() new API
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/38421/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 3003:                 try:
Line 3004:                     pvInfo = lvm.getPV(pv)
Line 3005:                 except se.InaccessiblePhysDev:
Line 3006:                     self.log.error("PV %s no longer exists", pv)
Line 3007:                     continue
> Does this mean that now getVGInfo and getVGList may silently return incompl
Previously we got None in pvInfo and when we tried to access its attributes we got an AttributeError. Now all we do is skip this pv and log the error. I think it's a better feedback than an exception, isn't it?
Line 3008:                 vgInfo['pvlist'].append(self.__fillPVDict(dev, pvInfo, vgType))
Line 3009: 
Line 3010:             if vgType == multipath.DEV_FCP:
Line 3011:                 vgType = sd.FCP_DOMAIN


-- 
To view, visit https://gerrit.ovirt.org/38421
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I583c0493093d2c9c8bca8713df8ee123c415de7f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Candace Sheremeta <cshereme at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list