Change in vdsm[ovirt-3.5]: API: getVMList: compatibity with internal clients
ybronhei at redhat.com
ybronhei at redhat.com
Thu Mar 19 09:06:44 UTC 2015
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: API: getVMList: compatibity with internal clients
......................................................................
API: getVMList: compatibity with internal clients
After the addition of the 'onlyUUID' parameter, the external
API of VDSM is now backward compatible:
- in XMLRPC, we always set explicitely onlyUUID=False, so no room for
breakage
- in JSONRPC, we have Host_getVMList_Call (short status), on which
* if onlyUUID is provided from the outside, we use it
(works with Engine >= 3.5.1)
* if onlyUUID is NOT given (Engine 3.5.0), we default as True,
and doing so we preserve the backward compatibility
- in JSONRPC, in Host_getVMFullList_Call (full status), we use
onlyUUID=False explicitely, so no issue hee
The internal API, however, changed behaviour.
Being the API internal, it doesn't usually need special care,
but this time we need, because MOM is a supported client of
this API.
With the current 'onlyUUID' defaults, clients of API.py
will get a list of UUIDs instead of a list of Short Status.
To fix this, and given the findings outlined in the above bullet points,
we just switch the default value of 'onlyUUID' to cover this use case.
Bug-Url: https://bugzilla.redhat.com/1196327
Related-To: https://bugzilla.redhat.com/1196735
Change-Id: I0560a262329f729716577b28aa78b177f0929121
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/38805
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/38868
Reviewed-by: Martin Sivák <msivak at redhat.com>
---
M vdsm/API.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Sivák: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
--
To view, visit https://gerrit.ovirt.org/38868
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
More information about the vdsm-patches
mailing list