Change in vdsm[ovirt-3.5]: API: onlyUUID should affect only short status

ybronhei at redhat.com ybronhei at redhat.com
Thu Mar 19 09:06:00 UTC 2015


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: API: onlyUUID should affect only short status
......................................................................


API: onlyUUID should affect only short status

this patch makes the 'onlyUUID' parameter take effect only
if 'fullStatus' equals False (short status was asked).

depending on 'fullStatus' boolean parameter, the getVMList API can
return either full or short VM status.
Due to a bug originally introduced before 3.5.0, short status
was incorrectly produced as list(UUIDs), but it is meant to be
a list(dict(vmId:UUID, status:vmStatus), )

The 'onlyUUID' parameter was added to preserve
backward compatibility with early Engines 3.5.x, but it is meant
to fix short status (fullStatus=False), and should not always affect
output.

Instead, the current code always produces short and broken status
if 'onlyUUID' equals True, with the side effect that also fullStatus
is affected.

Bug-Url: https://bugzilla.redhat.com/1196327
Related-To: https://bugzilla.redhat.com/1196735
Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/38679
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/38867
Reviewed-by: Martin Sivák <msivak at redhat.com>
---
M vdsm/API.py
M vdsm/rpc/Bridge.py
M vdsm/rpc/vdsmapi-schema.json
3 files changed, 8 insertions(+), 5 deletions(-)

Approvals:
  Martin Sivák: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/38867
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list