Change in vdsm[master]: split network restoration from vdsmd.service
osvoboda at redhat.com
osvoboda at redhat.com
Thu Mar 19 07:11:53 UTC 2015
Ondřej Svoboda has posted comments on this change.
Change subject: split network restoration from vdsmd.service
......................................................................
Patch Set 17: Code-Review-1
(5 comments)
Why --force had to be used?
https://gerrit.ovirt.org/#/c/29441/17//COMMIT_MSG
Commit Message:
Line 17: it's
its
Line 23: unaccessible
"inaccessible" is more common
https://gerrit.ovirt.org/#/c/29441/17/lib/vdsm/tool/restore_nets.py
File lib/vdsm/tool/restore_nets.py:
Line 41: '--force'
Why did you need to use --force?
https://gerrit.ovirt.org/#/c/29441/17/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:
Line 143: os.utime(file_path, None)
Line 144:
Line 145:
Line 146: def restore(force_restore=False):
Line 147: if not force_restore and _nets_already_restored(_NETS_RESTORED_MARK):
What if networks are _in the process_ of restoration, shouldn't we also use some kind of locking?
Line 148: logging.info('networks already restored. doing nothing.')
Line 149: return
Line 150:
Line 151: if config.get('vars', 'net_persistence') == 'unified':
Line 170: "the restore action first tests for an existence of " \
: "a mark that is made after the last successful " \
: "restore action. Unless this option is used, " \
: "restore will be a no-op if this mark exists."
Please use parentheses instead of slashes :-)
--
To view, visit https://gerrit.ovirt.org/29441
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70cdf1e8a1e7063ec850081ac6199728d4cde381
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <toni+ovirt at midokura.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni+ovirt at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list