Change in vdsm[master]: utils: add logged CPopen command execution

Federico Simoncelli fsimonce at redhat.com
Wed Mar 18 22:41:54 UTC 2015


Federico Simoncelli has posted comments on this change.

Change subject: utils: add logged CPopen command execution
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/38831/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 640:         parts.append(arg)
Line 641:     return ' '.join(parts)
Line 642: 
Line 643: 
Line 644: def loggedCPopen(args, close_fds=False, cwd=None, env=None, deathSignal=0,
> Why did you change the default close_fds from True to False?
Because I am using the CPopen defaults.
Line 645:                  childUmask=None, printable=None, logger=logging.root,
Line 646:                  level=logging.DEBUG):
Line 647:     if not printable:
Line 648:         printable = args


-- 
To view, visit https://gerrit.ovirt.org/38831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e04bde10be24457fe12362456e42528f9fd7196
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list