Change in vdsm[master]: hostdev: add after_hostdev_list_by_caps hook

fromani at redhat.com fromani at redhat.com
Wed Mar 18 16:43:53 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: hostdev: add after_hostdev_list_by_caps hook
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/38884/2//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: hostdev: add after_hostdev_list_by_caps hook
Line 8: 
Line 9: In order to allow oVirt deployment maintainers some customization over
Line 10: which host devices are hidden to oVirt or do modification/quirks for
about the flow, which I;m ashamed I'm not familiar enough with.

If I'm not mistaken, using this hook you can alter the devices representation at will.

So you can alter the listing of devices, meaning you can return a list of tampered (=alterend by the hook) device data.

Then, is it possible, and if so it is dangerous for us, that
the output will represent a device which is not be attachable?

For example, someone may be crazy enough to mess with the device address. What prevents that? If nothing does, are we concerned or endangered by this messing?
Line 11: specific hardware, new hook, after_hostdev_list_by_caps is introduced.
Line 12: This hook is another _json_hook, meaning that it receives device json
Line 13: representation and is free to modify it.
Line 14: 


-- 
To view, visit https://gerrit.ovirt.org/38884
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ab6b3fee49cea83266c77dbfcd8c08ed69c630e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list