Change in vdsm[master]: clusterLock: Make inquire retval consistent

danken at redhat.com danken at redhat.com
Wed Mar 18 15:15:01 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: clusterLock: Make inquire retval consistent
......................................................................


clusterLock: Make inquire retval consistent

Callers of clusterLock.inquire() expect a tuple with two values to be
returned.  The SANLock flavor gets this right but LocalLock returns a
single None when the lock has no owners.  It should return None, None.

Change-Id: Id4b9227773e44d48b21aa4eaba7c7fe1ab599931
Signed-off-by: Adam Litke <alitke at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/38552
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
---
M vdsm/storage/clusterlock.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Adam Litke: Verified
  Nir Soffer: Looks good to me, but someone else must approve
  Federico Simoncelli: Looks good to me, approved
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/38552
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id4b9227773e44d48b21aa4eaba7c7fe1ab599931
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Candace Sheremeta <cshereme at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list