Change in vdsm[master]: storage: Stop using tempnam in deleteImage

danken at redhat.com danken at redhat.com
Wed Mar 18 14:13:54 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: storage: Stop using tempnam in deleteImage
......................................................................


storage: Stop using tempnam in deleteImage

tempnam does not guarantee that the entire requested prefix is part of
the resulting file name but we rely on the whole prefix to be present to
identify the images for garbage collection.  tempnam is a bit of
overkill anyway since we already have a guaranteed unique file name (the
image UUID) and locking to prevent races.

Change-Id: I0ff87e735c12c94d704391286d1bfc451b442956
Signed-off-by: Adam Litke <alitke at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/38768
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/storage/fileSD.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Adam Litke: Verified
  Nir Soffer: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/38768
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0ff87e735c12c94d704391286d1bfc451b442956
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list