Change in vdsm[master]: vdscli: allow a connection with a configurable timeout
ybronhei at redhat.com
ybronhei at redhat.com
Wed Mar 18 13:05:51 UTC 2015
Yaniv Bronhaim has posted comments on this change.
Change subject: vdscli: allow a connection with a configurable timeout
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/38751/5/lib/vdsm/vdscli.py
File lib/vdsm/vdscli.py:
Line 117: wrap_transport(transport))
Line 118: else:
Line 119: # TODO: add timeout option for HTTP connection
Line 120: if timeout is not sslutils.SOCKET_DEFAULT_TIMEOUT:
Line 121: raise NotImplementedError
please add ('timeout is not supported in plaintext connection')
Line 122: transport = wrap_transport(SingleRequestTransport())
Line 123: server = xmlrpclib.Server('http://%s' % hostPort, transport)
Line 124: return server
Line 125:
--
To view, visit https://gerrit.ovirt.org/38751
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I10829e7491c1e3c917080664c0eea643f054247e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list