Change in vdsm[ovirt-3.5]: network: models: tag non-VDSM devices used by VDSM
phoracek at redhat.com
phoracek at redhat.com
Wed Mar 18 09:45:52 UTC 2015
Petr Horáček has posted comments on this change.
Change subject: network: models: tag non-VDSM devices used by VDSM
......................................................................
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/38771/1/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 2187: self.vdsm_net.save_config()
Line 2188:
Line 2189: @cleanupNet
Line 2190: @ValidateRunningAsRoot
Line 2191: def test_setupNetworks_on_external_vlaned_bond(self):
> maybe the train left already.
yep, it fails without this patch.
Line 2192: with dummyIf(1) as (nic, ):
Line 2193: with open(NET_CONF_PREF + nic, 'w') as f:
Line 2194: f.write("""DEVICE=%s
Line 2195: MASTER=%s
Line 2212: BOOTPROTO=static
Line 2213: NM_CONTROLLED=no
Line 2214: HOTPLUG=no""" % (BONDING_NAME, VLAN_ID))
Line 2215:
Line 2216: rc, _, _ = execCmd([EXT_IFUP, BONDING_NAME])
> might be worthwhile to check that those commands succeeded so the test won'
Done
Line 2217: rc, _, _ = execCmd([EXT_IFUP, BONDING_NAME + '.' + VLAN_ID])
Line 2218:
Line 2219: status, msg = self.vdsm_net.setupNetworks(
Line 2220: {NETWORK_NAME: {'bonding': BONDING_NAME, 'bridged': True,
--
To view, visit https://gerrit.ovirt.org/38771
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4d3ed2b45d618d404bb340100ca07bc57b2f1136
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni+ovirt at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list