Change in vdsm[master]: stomp: Pop the frame even if a frame handler isn't defined
piotr.kliczewski at gmail.com
piotr.kliczewski at gmail.com
Wed Mar 18 09:36:49 UTC 2015
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Pop the frame even if a frame handler isn't defined
......................................................................
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/35940/9/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line 438: parser.parse(data)
Line 439:
Line 440: frameHandler = self._frameHandler
Line 441: while parser.pending > 0:
Line 442: frameHandler.handle_frame(self, parser.popFrame())
> you still have the redundant frameHandler. and will handle_frame always exi
Yes, I checked and we do not need hasattr. I missed redundant frameHandler. Will fix.
Line 443:
Line 444: def popFrame(self):
Line 445: return self._parser.popFrame()
Line 446:
--
To view, visit https://gerrit.ovirt.org/35940
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cd3c5b9ad70cf49e1b105260548720d5b34ea9a
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list