Change in vdsm[master]: API: getVMList: compatibity with internal clients

fromani at redhat.com fromani at redhat.com
Tue Mar 17 08:24:07 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: API: getVMList: compatibity with internal clients
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/38805/2//COMMIT_MSG
Commit Message:

Line 27: With the current 'onlyUUID' defaults, clients of API.py
Line 28: will get a list of UUIDs instead of a list of Short Status.
Line 29: 
Line 30: To fix this, and given the findings outlined in the above bullet points,
Line 31: we just switch the default value of 'onlyUUID' to cover this use case.
> How this switch will work with engine 3.5.0? When you set it to False it wi
Let me elaborate a bit more.

In my original https://gerrit.ovirt.org/#/c/38172/ I fixed the return value inconditionally, but that broke old Engines.
The different return value caused ClassCastException.

Now we have the onlyUUID parameter to control the return value.

Bindings/Bridge must set this parameter explicitely and all the time. This is already done in code in 3.5.

Missing, apparently unused VM_getInfo is fixed in parent patch.

In Host_getVMList_Call, we already cover the case on which 'onlyUUID' is not sent by external client (Engine), and we use True in this case.

This is how we cover Engine 3.5.0, at least in theory.
Let's settle things by testing this theory on the field.
I'll do first verification step of this patch with VDSM master and VDSM 3.5.0 against Engine 3.5.0 (both XMLRPC and JSONRPC).
I'll extensively document my steps so we can review them as well. If this verification pass, we can go on, or I'll abandon this patch.
Line 32: 
Line 33: Change-Id: I0560a262329f729716577b28aa78b177f0929121


-- 
To view, visit https://gerrit.ovirt.org/38805
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list