Change in vdsm[master]: vm: method to check if dom is ready for commands

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Tue Mar 17 08:21:07 UTC 2015


Michal Skrivanek has posted comments on this change.

Change subject: vm: method to check if dom is ready for commands
......................................................................


Patch Set 27: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/36721/27/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3004:             state, details, stateTime = self._dom.controlInfo()
Line 3005:         except AttributeError:
Line 3006:             # this method may be called asynchronously by periodic
Line 3007:             # operations. Thus, we must use a try/except block
Line 3008:             # to avoid racy checks.
I'd still mention it more explicitly that as per usage in 36722 it's just a coarse-grained check used in bulk stats sampling when we encounter a bad VM
Line 3009:             return False
Line 3010:         else:
Line 3011:             return state == libvirt.VIR_DOMAIN_CONTROL_OK
Line 3012: 


-- 
To view, visit https://gerrit.ovirt.org/36721
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6fa253326778a102591af4ef5f2bb0434d1eade6
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list