Change in vdsm[master]: gluster: add createBrick verb

sbonazzo at redhat.com sbonazzo at redhat.com
Tue Mar 17 07:49:12 UTC 2015


Sandro Bonazzola has posted comments on this change.

Change subject: gluster: add createBrick verb
......................................................................


Patch Set 24:

(2 comments)

https://gerrit.ovirt.org/#/c/35498/24/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 162:         return vg
Line 163: 
Line 164:     def _createThinPool(poolName, vg, alignment=0,
Line 165:                         poolMetaDataSize=0, poolDataSize=0):
Line 166:         if alignment:
Please use shortest branch first.

Also, since the branch ends with a return, the else branch can be omitted.
Line 167:             metaName = "meta-%s" % poolName
Line 168:             vgPoolName = "%s/%s" % (vg.name, poolName)
Line 169:             metaLv = LVMLogicalVolumeDevice(
Line 170:                 metaName, parents=[vg],


Line 276:     blivetEnv.formatDevice(thinlv, format)
Line 277:     blivetEnv.doIt()
Line 278: 
Line 279:     if not os.path.exists(mountPoint):
Line 280:         os.makedirs(mountPoint)
Please use makedirs and handle the exception instead of testing the directory existence before creating it.
Line 281:     thinlv.format.setup(mountpoint=mountPoint)
Line 282:     blivetEnv.doIt()
Line 283:     fstab.FsTab().add(thinlv.path, mountPoint, DEFAULT_FS_TYPE)


-- 
To view, visit https://gerrit.ovirt.org/35498
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic47c4c56834deb457ae9d038f77bcf69c7b39ba5
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list