Change in vdsm[master]: vdscliTests: add a test for connect with a timeout

danken at redhat.com danken at redhat.com
Mon Mar 16 21:52:55 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: vdscliTests: add a test for connect with a timeout
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/38806/1/tests/vdsClientTests.py
File tests/vdsClientTests.py:

Line 524: 
Line 525: class ConnectTest(TestCaseBase):
Line 526: 
Line 527:     @ValidateRunningAsRoot
Line 528:     def testTimeout(self):
indeed - it should be moved to the "functional" subdir.
Line 529:         c = vdscli.connect(useSSL=True,
Line 530:                            tsPath='/etc/pki/vdsm',
Line 531:                            timeout=0.01)
Line 532:         self.assertRaises(SSLError, c.getVdsStats)


Line 525: class ConnectTest(TestCaseBase):
Line 526: 
Line 527:     @ValidateRunningAsRoot
Line 528:     def testTimeout(self):
Line 529:         c = vdscli.connect(useSSL=True,
why specific useSSL explicitly? the currently-running vdsmd may use plaintext.
Line 530:                            tsPath='/etc/pki/vdsm',
Line 531:                            timeout=0.01)
Line 532:         self.assertRaises(SSLError, c.getVdsStats)
Line 533: 


-- 
To view, visit https://gerrit.ovirt.org/38806
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21793986338a00caa1163c7f9297d160a9d1fc45
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list