Change in vdsm[master]: hsm: Add refresh device verb

nsoffer at redhat.com nsoffer at redhat.com
Mon Mar 16 21:47:12 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: hsm: Add refresh device verb
......................................................................


Patch Set 4:

(3 comments)

https://gerrit.ovirt.org/#/c/38754/4/client/vdsClient.py
File client/vdsClient.py:

Line 722:         pp.pprint(devices['devList'])
Line 723:         return 0, ''
Line 724: 
Line 725:     def refreshDevice(self, args):
Line 726:         validateArgTypes(args, [str], requiredArgsNumber=1)
Nice! I forgot about this utility.
Line 727:         guid = args[0]
Line 728:         res = self.s.refreshDevice(guid)
Line 729:         if res['status']['code']:
Line 730:             return res['status']['code'], res['status']['message']


Line 728:         res = self.s.refreshDevice(guid)
Line 729:         if res['status']['code']:
Line 730:             return res['status']['code'], res['status']['message']
Line 731:         del res['status']
Line 732:         printDict(res, self.pretty)
Returning the size as is is probably more useful since we have only one value, but this is consistent with other code like getVolumeSize.
Line 733:         return 0, ''
Line 734: 
Line 735:     def getDevicesVisibility(self, args):
Line 736:         devList = args[0].split(',')


Line 2220:                            'storageType).'
Line 2221:                            )),
Line 2222:         'refreshDevice': (serv.refreshDevice,
Line 2223:                           ('<GUID>',
Line 2224:                            'Refresh Multipath device'
Multipath -> multipath.

I think we need little more documentation here, what does this refresh mean - updating the device size after it was resized on the storage server.
Line 2225:                            )),
Line 2226:         'getDevicesVisibility': (serv.getDevicesVisibility,
Line 2227:                                  ('<devlist>',
Line 2228:                                   'Get visibility of each device listed'


-- 
To view, visit https://gerrit.ovirt.org/38754
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6fbeec7920a7943a9b1ea9dbd93477fa9b642f5b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list