Change in vdsm[master]: asyncore: Move generic reactor functionality

danken at redhat.com danken at redhat.com
Mon Mar 16 21:31:17 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: asyncore: Move generic reactor functionality
......................................................................


asyncore: Move generic reactor functionality

This is part of a larger move to unify the protocol detector and the
stomp reactor.

In this phase we move all the functionality not specific to stomp to a
generic Reactor class.

This patch still keeps the original StompReactor to minimize changes
outside of yajsonrpc.

Change-Id: I59a14b18f4c08d873763e1d3bd9d42b99de05fb1
Signed-off-by: Saggi Mizrahi <smizrahi at redhat.com>
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
Reviewed-on: https://gerrit.ovirt.org/37055
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/yajsonrpc/betterAsyncore.py
M lib/yajsonrpc/stompReactor.py
2 files changed, 53 insertions(+), 24 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/37055
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I59a14b18f4c08d873763e1d3bd9d42b99de05fb1
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list