Change in vdsm[master]: API: onlyUUID should affect only short status

fromani at redhat.com fromani at redhat.com
Mon Mar 16 16:30:35 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: API: onlyUUID should affect only short status
......................................................................


Patch Set 4:

Given the last concerns about MOM compatibility (being a proper Fedora Package, may break some 3.3/3.4 setups)

assuming we do want to follow onlyUUID with fullStatus=False only, so we want this patch in:

I did a careful review of all the possible flows, and it seems that

- in XMLRPC, we always set explicitely onlyUUID=False, so no room for breakage
- in JSONRPC, we have Host_getVMList_Call (short status!), on which
  - if onlyUUID is provided from the outside, we use it (Engine >= 3.5.1)
  - if onlyUUID is NOT given (Engine 3.5.0), we default as True,
    and doing so we preserve the backward compatibility
- in JSONRPC, in Host_getVMFullList_Call (full status), we use onlyUUID=False explicitely, so no issue hee
  
So, if the above analysis is correct, it seems we always pass the correct value to onlyUUID and, moreover, we never relies on its default values.

Then, it seems legit to switch the default values to the one which also preserves MOM backward compatibility (onlyUUID=False), because

- in API.py, we need to be backward compatible with MOM, which calls 
  getVMList both with FullStatus=True and without any arguments.

Please review the above and tell me what is wrong. If everything's right, we may able to just switch default, drop the MOM patch(es) and fix the remaining issues with just this patch.

-- 
To view, visit https://gerrit.ovirt.org/38679
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list