Change in vdsm[master]: vdscli: allow a connection with a configurable timeout

danken at redhat.com danken at redhat.com
Mon Mar 16 15:52:13 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: vdscli: allow a connection with a configurable timeout
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/38751/2/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:

Line 197: 
Line 198: class VerifyingSafeTransport(xmlrpclib.SafeTransport):
Line 199:     def __init__(self, use_datetime=0, key_file=None, cert_file=None,
Line 200:                  ca_certs=None, cert_reqs=ssl.CERT_REQUIRED,
Line 201:                  timeout=SOCKET_DEFAULT_TIMEOUT):
sslutilTests uses timeout in a different, possibly incompatible, way.

Please add a test for the new arg, and make sure that the current tests make sense (or need to be changed to use the new arg)
Line 202:         xmlrpclib.SafeTransport.__init__(self, use_datetime)
Line 203:         self.key_file = key_file
Line 204:         self.cert_file = cert_file
Line 205:         self.ca_certs = ca_certs


-- 
To view, visit https://gerrit.ovirt.org/38751
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10829e7491c1e3c917080664c0eea643f054247e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list