Change in vdsm[master]: tests: add more tests for custom error responses

fromani at redhat.com fromani at redhat.com
Mon Mar 16 12:56:26 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: tests: add more tests for custom error responses
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/38665/3/tests/vmTests.py
File tests/vmTests.py:

Line 1058: 
Line 1059:                 res = testvm.updateDevice(
Line 1060:                     self._getGraphicsDeviceParams(device))
Line 1061: 
Line 1062:                 self.assertErrorResponse(res, 'ticketErr', message)
> Isn't this equal to:
Will simplify this patch and avoid new helper class.
Line 1063: 
Line 1064: 
Line 1065: VM_EXITS = tuple(product((define.NORMAL, define.ERROR),
Line 1066:                  vmexitreason.exitReasons.keys()))


-- 
To view, visit https://gerrit.ovirt.org/38665
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf3d03f125f9c53339d9ad7fef8c31482bab0bfb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list